Re: Bump MIN_WINNT to 0x0600 (Vista) as minimal runtime in 16~

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
Cc: Daniel Gustafsson <daniel(at)yesql(dot)se>, Juan José Santamaría Flecha <juanjo(dot)santamaria(at)gmail(dot)com>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Bump MIN_WINNT to 0x0600 (Vista) as minimal runtime in 16~
Date: 2022-07-06 07:27:57
Message-ID: YsU5fb0ceDADr2Ti@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Jun 16, 2022 at 03:14:16PM +0900, Michael Paquier wrote:
> Actually, this can go with the bump of MIN_WINNT as it uses one of the
> IsWindows*OrGreater() macros as a runtime check. And there are two
> more places in pg_ctl.c that can be similarly cleaned up.
>
> It is possible that I have missed some spots, of course.

It does not seem to be the case on a second look. The buildfarm
animals running Windows are made of:
- hamerkop, Windows server 2016 (based on Win10 AFAIK)
- drongo, Windows server 2019
- bowerbird, Windows 10 pro
- jacana, Windows 10
- fairywren, Msys server 2019
- bichir, Ubuntu/Windows 10 mix

Now that v16 is open for business, any objections to move on with this
patch and bump MIN_WINNT to 0x0A00 on HEAD? There are follow-up items
for large pages and more.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2022-07-06 07:45:31 Re: doc: BRIN indexes and autosummarize
Previous Message Peter Eisentraut 2022-07-06 06:51:37 Re: refactor some protocol message sending in walsender and basebackup