Re: Bump MIN_WINNT to 0x0600 (Vista) as minimal runtime in 16~

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
Cc: Daniel Gustafsson <daniel(at)yesql(dot)se>, Juan José Santamaría Flecha <juanjo(dot)santamaria(at)gmail(dot)com>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Bump MIN_WINNT to 0x0600 (Vista) as minimal runtime in 16~
Date: 2022-06-16 06:14:16
Message-ID: YqrKOPvi/
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On Thu, Jun 09, 2022 at 02:47:36PM +0900, Michael Paquier wrote:
> On Thu, Jun 09, 2022 at 04:55:45PM +1200, Thomas Munro wrote:
>> I think we can drop mention of Itanium (RIP): the ancient versions of
>> Windows that could run on that arch are desupported with your patch.
>> It might be more relevant to say that we can't yet run on ARM, and
>> Windows 11 is untested by us, but let's fix those problems instead of
>> documenting them :-)
> Okay to remove the Itanium part for me.

install-windows.sgml has one extra spot mentioning Windows 7 and
Server 2008 that can be simplified on top of that.

>> There are more mentions of older Windows releases near the compiler
>> stuff but perhaps your MSVC version vacuuming work will take care of
>> those.
> Yes, I have a few changes like the one in main.c for _M_AMD64. Are
> you referring to something else?

Actually, this can go with the bump of MIN_WINNT as it uses one of the
IsWindows*OrGreater() macros as a runtime check. And there are two
more places in pg_ctl.c that can be similarly cleaned up.

It is possible that I have missed some spots, of course.

Attachment Content-Type Size
v3-0001-Bump-WIN_MINNT-to-0x0A00-everywhere-Windows-10.patch text/x-diff 7.7 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Mark Dilger 2022-06-16 06:23:09 Re: Modest proposal to extend TableAM API for controlling cluster commands
Previous Message Amit Langote 2022-06-16 06:13:07 Re: Replica Identity check of partition table on subscriber