| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: pgsql: Add TAP test for archive_cleanup_command and recovery_end_comman |
| Date: | 2022-04-18 04:55:13 |
| Message-ID: | YlzvMeOnn/u8Z8MH@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Tue, Apr 12, 2022 at 12:49:48PM +0900, Michael Paquier wrote:
> This comes from df86e52, where we want to recovery a history file that
> would be created as RECOVERYHISTORY and make sure that the file gets
> removed at the end of recovery. So $standby2 should choose a new
> timeline different from the one of chosen by $standby. Looking back
> at what has been done, it seems to me that the comment is the
> incorrect part:
> https://www.postgresql.org/message-id/20190930080340.GO2888@paquier.xyz
acf1dd42 has taken care of the failures of this test with skink, and I
have just taken care of the two races in the tests with e61efaf and
1a8b110. I have left e61efaf out of REL_10_STABLE as the idea of
relying on a poll_query_until() with pg_stat_file() and an absolute
path would not work there, and the branch will be EOL'd soon while
there were no complains with this test for two years.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2022-04-18 16:17:17 | pgsql: Avoid invalid array reference in transformAlterTableStmt(). |
| Previous Message | Michael Paquier | 2022-04-18 04:42:59 | pgsql: Fix second race condition in 002_archiving.pl with archive_clean |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2022-04-18 05:49:14 | Re: Stabilizing the test_decoding checks, take N |
| Previous Message | Amit Kapila | 2022-04-18 04:35:44 | Re: Logical replication timeout problem |