pgsql: Fix second race condition in 002_archiving.pl with archive_clean

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Fix second race condition in 002_archiving.pl with archive_clean
Date: 2022-04-18 04:42:59
Message-ID: E1ngJE3-0011kV-JU@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix second race condition in 002_archiving.pl with archive_cleanup_command

Checking the execution of archive_cleanup_command on a standby requires
a valid checkpoint coming from its primary, but the logic did not check
that the standby replayed up to the point of the checkpoint, causing the
test checking for the execution of archive_cleanup_command to fail.
This race was more visible in slow environments.

Issue introduced in 46dea24, so no backpatch is needed.

Author: Tom Lane
Discussion: https://postgr.es/m/4015413.1649454951@sss.pgh.pa.us

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/1a8b110539efe18803c1fa8aa452a2178dbad9a9

Modified Files
--------------
src/test/recovery/t/002_archiving.pl | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2022-04-18 04:55:13 Re: pgsql: Add TAP test for archive_cleanup_command and recovery_end_comman
Previous Message Amit Kapila 2022-04-18 03:21:58 pgsql: Add additional documentation for row filters.