| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Julien Rouhaud <rjuju123(at)gmail(dot)com> |
| Cc: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, okano(dot)naoki(at)jp(dot)fujitsu(dot)com, PostgreSQL mailing lists <pgsql-bugs(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: BUG #17448: In Windows 10, version 1703 and later, huge_pages doesn't work. |
| Date: | 2022-04-01 05:59:22 |
| Message-ID: | YkaUuhwppy2hiBi9@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs pgsql-hackers |
On Thu, Mar 31, 2022 at 07:03:09PM +0800, Julien Rouhaud wrote:
> There's no such indication on IsWindowsVersionOrGreater(), but after seeing
> various comments on forums from angry people, it may be a hint that it behaves
> similarly. I'm not sure what to do at this point, maybe just always use the
> flag (the PG_ version which may be 0), hoping that hopefully windows won't
> define it if it can't handle it?
Looking at the internals of versionhelpers.h, would it work to use as
arguments for IsWindowsVersionOrGreater() the following, in this
order? As of:
- HIBYTE(_WIN32_WINNT_WINTHRESHOLD)
- LOBYTE(_WIN32_WINNT_WINTHRESHOLD)
- 1703
Just to drop an idea.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Julien Rouhaud | 2022-04-01 06:19:46 | Re: BUG #17448: In Windows 10, version 1703 and later, huge_pages doesn't work. |
| Previous Message | Michael Paquier | 2022-04-01 05:54:53 | Re: BUG #17448: In Windows 10, version 1703 and later, huge_pages doesn't work. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2022-04-01 06:01:38 | Re: Rewriting the test of pg_upgrade as a TAP test - take three - remastered set |
| Previous Message | Kyotaro Horiguchi | 2022-04-01 05:59:19 | Re: Higher level questions around shared memory stats |