Re: pgsql: Add support for building with ZSTD.

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: pgsql: Add support for building with ZSTD.
Date: 2022-02-21 01:02:58
Message-ID: YhLkwodatZTnoHO4@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Sun, Feb 20, 2022 at 09:45:05AM -0500, Robert Haas wrote:
> No issues at all with you adjusting this, but I think that sentence
> reads a little awkwardly.

Thanks.

> Perhaps instead of "The default is
> <literal>zstd</literal>, that would be the command found in
> <varname>PATH</varname>." you could write something like "The default
> is <literal>zstd</literal>, which will search for a command by that
> name in the configured <varname>PATH</varname>." Or maybe something
> else is better, not sure exactly, your version just seems a little odd
> to me.

Okay, done then. We've been using the same wording for all the other
variables, and what you are suggesting here sounds much better to me,
so I have adjusted all the descriptions this way, and added the ZSTD
part.
--
Michael

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2022-02-21 08:46:23 pgsql: Fix possible null pointer reference
Previous Message Michael Paquier 2022-02-21 01:00:52 pgsql: doc: Mention environment variable ZSTD in the TAP tests for MSVC

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2022-02-21 01:07:25 Re: pg_upgrade verbosity when redirecting output to log file
Previous Message Corey Huinker 2022-02-21 00:53:47 Re: WIP: System Versioned Temporal Table