Re: pg_upgrade verbosity when redirecting output to log file

From: Andres Freund <andres(at)anarazel(dot)de>
To: Justin Pryzby <pryzby(at)telsasoft(dot)com>
Cc: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: pg_upgrade verbosity when redirecting output to log file
Date: 2022-02-21 01:07:25
Message-ID: 20220221010725.ft4qaialjyxpmivm@alap3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On 2022-02-18 19:46:26 -0600, Justin Pryzby wrote:
> + * If outputting to a tty / or , append newline. pg_log_v() will put the
> + * individual progress items onto the next line.
> + */
> + if (log_opts.isatty || log_opts.verbose)
>
> I guess the comment should say "or in verbose mode".

Indeed. I think I got caught in a back-and-forth between different
formulations.

Baring that, anybody against committing this?

Greetings,

Andres Freund

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2022-02-21 01:07:59 Re: Uniforms the errors msgs at tuplestore paths
Previous Message Michael Paquier 2022-02-21 01:02:58 Re: pgsql: Add support for building with ZSTD.