| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Justin Pryzby <pryzby(at)telsasoft(dot)com> |
| Cc: | Kasahara Tatsuhito <kasahara(dot)tatsuhito(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Small and unaffected typo in pg_logical_slot_get_changes_guts() |
| Date: | 2022-02-16 05:34:00 |
| Message-ID: | YgyMyPkm3htx6l7L@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Feb 15, 2022 at 11:23:29PM -0600, Justin Pryzby wrote:
> On Wed, Feb 16, 2022 at 11:27:58AM +0900, Kasahara Tatsuhito wrote:
>> - tuplestore_donestoring(tupstore);
>> + tuplestore_donestoring(p->tupstore);
>
> Melanie's tuplestore patch also removes the bogus line.
> https://www.postgresql.org/message-id/20220106005748.GT14051%40telsasoft.com
Thanks for the pointer! Kasahara-san's patch is doing the job, and I
can see that this does not really influence Melanie's patch, so I
would suggest to move on with this clean up. I'll go ping the other
thread about that part, first, of course.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2022-02-16 05:43:08 | Re: make tuplestore helper function |
| Previous Message | Kyotaro Horiguchi | 2022-02-16 05:26:37 | Re: Race conditions in 019_replslot_limit.pl |