Re: adding 'zstd' as a compression algorithm

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Justin Pryzby <pryzby(at)telsasoft(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: adding 'zstd' as a compression algorithm
Date: 2022-02-16 02:33:19
Message-ID: YgxibzZ0F8aIRWK9@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Feb 15, 2022 at 02:33:32PM -0600, Justin Pryzby wrote:
> What I mean is that any patches which *use* the zstd support should update
> those for completeness.
>
> doc/src/sgml/config.sgml | 14 +++++++++-----
> doc/src/sgml/install-windows.sgml | 2 +-
> doc/src/sgml/installation.sgml | 5 +++--

Yes, the patch misses the fact that each ./configure switch is
documented. For consistency, I think that you should also add that in
the MSVC scripts in the first version. It is really straight-forward
to do so, and it should be just a matter of grepping for the code
paths of lz4, then adjust things for zstd.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Thomas Munro 2022-02-16 02:34:08 Re: USE_BARRIER_SMGRRELEASE on Linux?
Previous Message Kasahara Tatsuhito 2022-02-16 02:27:58 Small and unaffected typo in pg_logical_slot_get_changes_guts()