Small and unaffected typo in pg_logical_slot_get_changes_guts()

From: Kasahara Tatsuhito <kasahara(dot)tatsuhito(at)gmail(dot)com>
To: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Small and unaffected typo in pg_logical_slot_get_changes_guts()
Date: 2022-02-16 02:27:58
Message-ID: CAP0=ZVJeeYfAeRfmzqAF2Lumdiv4S4FewyBnZd4DPTrsSQKJKw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

I noticed the small typo in pg_logical_slot_get_changes_guts().

======================================
--- a/src/backend/replication/logical/logicalfuncs.c
+++ b/src/backend/replication/logical/logicalfuncs.c
@@ -295,7 +295,7 @@ pg_logical_slot_get_changes_guts(FunctionCallInfo
fcinfo, bool confirm, bool bin
CHECK_FOR_INTERRUPTS();
}

- tuplestore_donestoring(tupstore);
+ tuplestore_donestoring(p->tupstore);
======================================

As above, I think tuplestore_donestoring() should have p->tupstore as
an argument.
Fortunately, tuplestore_donestoring() is defined as ((void) 0) and
does not do anything. Therefore, this typo has no effect

However, it is better to fix the typo or remove the
tuplestore_donestoring() part to avoid confusion.

Since commit dd04e958c8b03c0f0512497651678c7816af3198,
tuplestore_donestoring() seems to be left only for compatibility, so
it looks like it can be removed from the core code, except for the
header (tuplestore.h).

Best regards,

--
Tatsuhito Kasahara
kasahara.tatsuhito _at_ gmail.com

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2022-02-16 02:33:19 Re: adding 'zstd' as a compression algorithm
Previous Message Andres Freund 2022-02-16 02:24:13 Re: adding 'zstd' as a compression algorithm