Re: Possible uninitialized use of the variables (src/backend/access/transam/twophase.c)

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>
Cc: ranier(dot)vf(at)gmail(dot)com, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Possible uninitialized use of the variables (src/backend/access/transam/twophase.c)
Date: 2022-02-14 02:07:19
Message-ID: Ygm5V91SwQPenkFn@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Feb 10, 2022 at 11:38:44AM +0900, Michael Paquier wrote:
> The proposed change is incomplete anyway once you consider this
> argument. First, there is no need to set up those fields in
> EndPrepare() anymore if there is no origin data, no? It would be good
> to comment that these are filled in EndPrepare(), I guess, once you do
> the initialization in StartPrepare().

That still looked better on a fresh look in terms of consistency, so
applied this way.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Thomas Munro 2022-02-14 02:29:08 Re: buildfarm warnings
Previous Message Michael Paquier 2022-02-14 02:03:44 Re: pgsql: Add TAP test to automate the equivalent of check_guc