| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Ronan Dunklau <ronan(dot)dunklau(at)aiven(dot)io> |
| Cc: | Julien Rouhaud <rjuju123(at)gmail(dot)com>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Proposal: More structured logging |
| Date: | 2022-01-27 07:15:01 |
| Message-ID: | YfJGdcoaTWJ9HLmF@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Jan 18, 2022 at 06:46:03AM +0100, Ronan Dunklau wrote:
> Hum, there was a missing import in csvlog.c from the fix above. Sorry about
> that.
+<!-- Don't forget to also update file_fdw.sgml if you change this
table definition -->
<programlisting>
You are also forgetting that the table listing all the jsonlog fields
needs a refresh with this new key called "tags", and that it has a
JSON object underneath.
If you want to test all the formats supported by logging_destination,
wouldn't this stuff be better if tested through TAP with
logging_destination set with csvlog, jsonlog and stderr? This is
lacking coverage for csvlog.c and jsonlog.c, paths touched by your
patch.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kyotaro Horiguchi | 2022-01-27 07:24:34 | Re: TAP test to cover "EndOfLogTLI != replayTLI" case |
| Previous Message | Michael Paquier | 2022-01-27 06:58:17 | Re: PITR: enhance getRecordTimestamp() |