Re: XLogReadRecord() error in XlogReadTwoPhaseData()

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Noah Misch <noah(at)leadboat(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: XLogReadRecord() error in XlogReadTwoPhaseData()
Date: 2021-11-09 01:51:40
Message-ID: YYnULGEY0WNK2lXx@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Nov 08, 2021 at 01:42:46PM +0900, Michael Paquier wrote:
> Indeed. Looking closer, I think that we'd better improve
> DecodingContextFindStartpoint(),
> pg_logical_replication_slot_advance(), XLogSendLogical() as well as
> pg_logical_slot_get_changes_guts() to follow a format closer to what
> you have in your patch, with an error message that describes the
> context where the problem has been found, instead of just elog()'ing
> what XLogReadRecord() returns.

FYI, I have just begun a new thread about those ones:
https://www.postgresql.org/message-id/YYnTH6OyOwQcAdkw@paquier.xyz
--
Michael

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2021-11-09 02:00:41 Re: Commitfest 2021-11 Patch Triage - Part 1
Previous Message Peter Smith 2021-11-09 01:49:50 Re: Added schema level support for publication.