Improve error context after some failed XLogReadRecord()

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Improve error context after some failed XLogReadRecord()
Date: 2021-11-09 01:47:11
Message-ID: YYnTH6OyOwQcAdkw@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi all,

I have noticed $subject while looking at a patch in this area:
https://www.postgresql.org/message-id/YYiqxtEqhgb5gIWL@paquier.xyz

While we don't expect the four callers of XLogReadRecord() related to
logical decoding to fail in the code paths changed by the patch
attached, I think that it would be good to provide more context to
users rather than just emitting an elog(ERROR) coming directly from
the WAL reader. This way, it becomes a bit easier to guess from where
the failure is coming.

A patch is attached to improve all those elog()s. I have tried not to
be too fancy about those new error strings, but I am sure that these
could be tweaked.

Thoughts?
--
Michael

Attachment Content-Type Size
xlogreader-errs.patch text/x-diff 2.3 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Smith 2021-11-09 01:49:50 Re: Added schema level support for publication.
Previous Message Michael Paquier 2021-11-09 00:53:15 Re: Make mesage at end-of-recovery less scary.