Re: Clean up build warnings of plperl with clang-12+

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Clean up build warnings of plperl with clang-12+
Date: 2021-11-11 22:22:44
Message-ID: YY2XtO4kGuTyP7mq@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Nov 11, 2021 at 01:18:32PM -0500, Tom Lane wrote:
> I see you tried to do that by adding -Werror to CPPFLAGS. That doesn't
> work because it breaks configure's tests. (I wonder if meson is any
> smarter than autoconf about that.) The way I do it on my own
> animals is like

Nya. (Japanized Meh)

> if ($branch eq 'HEAD' or $branch ge 'REL9_3')
> {
> # Add -Werror so we get errors for warning conditions.
> # Pre-9.3 PG doesn't compile cleanly with Sierra's cc.
> # Can't put this in CFLAGS because it breaks configure,
> # so use COPT instead.
> $conf{build_env}{COPT} = "-Werror";
> }
>
> Guess I could drop the branch check now.

Thanks. I'll switch to something like that.
--
Michael

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Greg Nancarrow 2021-11-11 22:44:06 Re: On login trigger: take three
Previous Message Daniel Gustafsson 2021-11-11 22:12:23 Commitfest 2021-11 Patch Triage - Part 3