From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Michael Paquier <michael(at)paquier(dot)xyz> |
Cc: | Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: Clean up build warnings of plperl with clang-12+ |
Date: | 2021-11-11 18:18:32 |
Message-ID: | 1576326.1636654712@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Michael Paquier <michael(at)paquier(dot)xyz> writes:
> Backpatched this one as of 9ff47ea. That should allow the addition of
> -Werror on dangomushi.
I see you tried to do that by adding -Werror to CPPFLAGS. That doesn't
work because it breaks configure's tests. (I wonder if meson is any
smarter than autoconf about that.) The way I do it on my own
animals is like
if ($branch eq 'HEAD' or $branch ge 'REL9_3')
{
# Add -Werror so we get errors for warning conditions.
# Pre-9.3 PG doesn't compile cleanly with Sierra's cc.
# Can't put this in CFLAGS because it breaks configure,
# so use COPT instead.
$conf{build_env}{COPT} = "-Werror";
}
Guess I could drop the branch check now.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2021-11-11 18:22:59 | Re: unexpected plan with id = any('{}') condition |
Previous Message | Sergei Kornilov | 2021-11-11 18:15:54 | Re:unexpected plan with id = any('{}') condition |