Re: Memory leak in pg_hmac_final

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Daniel Gustafsson <daniel(at)yesql(dot)se>
Cc: Sergey Shinderuk <s(dot)shinderuk(at)postgrespro(dot)ru>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Memory leak in pg_hmac_final
Date: 2021-10-02 05:25:44
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On Fri, Oct 01, 2021 at 10:58:07PM +0200, Daniel Gustafsson wrote:
> Nice, I hadn't heard of that before but it seems quite neat.

Thanks for the fix, it looks fine. I just saw the thread. Perhaps
the commit log should have said that this only impacts non-OpenSSL
builds. Worth noting that in ~13 we used a static buffer for "h" in
the SCRAM code, as its size was known thanks to SHA-256.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2021-10-02 05:30:51 Re: 2021-09 Commitfest
Previous Message Daniel Fone 2021-10-02 03:48:24 Re: pgcrypto support for bcrypt $2b$ hashes