Re: Memory leak in pg_hmac_final

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Sergey Shinderuk <s(dot)shinderuk(at)postgrespro(dot)ru>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Memory leak in pg_hmac_final
Date: 2021-10-01 20:58:07
Message-ID: 73AB4B2E-6099-4318-9B27-A83553B478BB@yesql.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 1 Oct 2021, at 14:31, Sergey Shinderuk <s(dot)shinderuk(at)postgrespro(dot)ru> wrote:
>
> On 01.10.2021 15:05, Daniel Gustafsson wrote:
>>> On 1 Oct 2021, at 12:39, Sergey Shinderuk <s(dot)shinderuk(at)postgrespro(dot)ru> wrote:
>>
>>> Here is a patch fixing the subject.
>>
>> Seems reasonable on a quick glance, the interim h buffer should be freed (this
>> is present since 14). I'll have another look at this in a bit and will take
>> care of it.

Patch pushed to master and 14.

> Thanks. I found it using the leaks tool on macOS.

Nice, I hadn't heard of that before but it seems quite neat.

--
Daniel Gustafsson https://vmware.com/

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Daniel Gustafsson 2021-10-01 21:20:09 Re: libpq compression
Previous Message Paul A Jungwirth 2021-10-01 20:47:57 Re: SQL:2011 application time