Re: pg_upgrade test for binary compatibility of core data types

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Justin Pryzby <pryzby(at)telsasoft(dot)com>
Cc: Jacob Champion <pchampion(at)vmware(dot)com>, tgl(at)sss(dot)pgh(dot)pa(dot)us, peter(dot)eisentraut(at)enterprisedb(dot)com, pgsql-hackers(at)lists(dot)postgresql(dot)org, buschmann(at)nidsa(dot)net, andrew(at)dunslane(dot)net, noah(at)leadboat(dot)com, tomas(dot)vondra(at)2ndquadrant(dot)com, bruce(at)momjian(dot)us, andres(at)anarazel(dot)de
Subject: Re: pg_upgrade test for binary compatibility of core data types
Date: 2021-10-01 07:58:41
Message-ID: YVa/
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-bugs pgsql-hackers

On Sat, Sep 11, 2021 at 07:51:16PM -0500, Justin Pryzby wrote:
> These are all "translated" from, so follow its logic.
> Maybe it should be improved, but that's separate from this patch - which is
> already doing a few unrelated things.

I was looking at this CF entry, and what you are doing in 0004 to move
the tweaks from pg_upgrade's to a separate SQL script that
uses psql's meta-commands like \if to check which version we are on is
really interesting. The patch does not apply anymore, so this needs a
rebase. The entry has been switched as waiting on author by Tom, but
you did not update it after sending the new versions in [1]. I am
wondering if we could have something cleaner than just a set booleans
as you do here for each check, as that does not help with the
readability of the tests.


In response to


Browse pgsql-bugs by date

  From Date Subject
Next Message PG Bug reporting form 2021-10-01 12:16:55 BUG #17209: The latest pgdg-redhat-repo-latest.noarch has incorrect path for pgdg14
Previous Message Michael Paquier 2021-10-01 06:09:19 Re: BUG #17205: pg_class.reltuples vakue wrong for brin indexes after vacuum (by many orders of magnitude)

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2021-10-01 08:01:33 Re: create table like: ACCESS METHOD
Previous Message Kyotaro Horiguchi 2021-10-01 07:40:36 Re: Allow escape in application_name