Re: strange case of "if ((a & b))"

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
Cc: Justin Pryzby <pryzby(at)telsasoft(dot)com>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Peter Smith <smithpb2250(at)gmail(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: strange case of "if ((a & b))"
Date: 2021-10-07 07:49:10
Message-ID: YV6mdqdDDJ4QX+t3@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Oct 07, 2021 at 03:24:53PM +0900, Masahiko Sawada wrote:
> Indeed. I've attached a patch that also deals with "false : true" cases.

Looks right. I would be tempted to keep the one in readfuncs.c
though, mostly as a matter of style, and I would add a comparison with
NULL for the return result of bsearch() in ts_utils.c.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message katouknl 2021-10-07 08:14:43 Re: [PATCH] Added TRANSFORM FOR for COMMENT tab completion
Previous Message Michael Paquier 2021-10-07 07:25:17 Re: Add jsonlog log_destination for JSON server logs