Re: strange case of "if ((a & b))"

From: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Justin Pryzby <pryzby(at)telsasoft(dot)com>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Peter Smith <smithpb2250(at)gmail(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: strange case of "if ((a & b))"
Date: 2021-10-07 06:24:53
Message-ID: CAD21AoCzxx+8FyZxZ3DucOQbr4R8_thF70cmHiAndRyAcXW_TA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Oct 7, 2021 at 1:37 PM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Thu, Oct 07, 2021 at 01:27:34PM +0900, Masahiko Sawada wrote:
> > On Thu, Oct 7, 2021 at 11:44 AM Justin Pryzby <pryzby(at)telsasoft(dot)com> wrote:
> >> I'm not quite sure how you managed to search for it - well done ;)
> >
> > I could not find the recent thread, though :)
>
> Hm. It looks like there are more occurences of "false : true" that
> could be cleaned up, like in nodeResult.c or tablecmds.c.

Indeed. I've attached a patch that also deals with "false : true" cases.

Regards,

--
Masahiko Sawada
EDB: https://www.enterprisedb.com/

Attachment Content-Type Size
remove_unnecessary_ternary_operations_v2.patch application/octet-stream 5.3 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Langote 2021-10-07 07:09:24 Re: [BUG] Unexpected action when publishing partition tables
Previous Message Bossart, Nathan 2021-10-07 06:00:08 Re: Add jsonlog log_destination for JSON server logs