Re: More business with $Test::Builder::Level in the TAP tests

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: More business with $Test::Builder::Level in the TAP tests
Date: 2021-10-07 01:53:57
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On Wed, Oct 06, 2021 at 07:33:22AM -0400, Andrew Dunstan wrote:
> We should probably state a requirement for this somewhere. Maybe in
> src/test/perl/README. AIUI, the general rule is that any subroutine that
> directly or indirectly calls ok() and friends should increase the level.
> Such subroutines that don't increase it should probably contain a
> comment stating why, so we can know in future that it's not just an
> oversight.

That makes sense. How about something like that after the part about
Test::More::like and qr// in the section about writing tests? Here it
+Test::Builder::Level controls how far up in the call stack a test will look
+at when reporting a failure. This should be incremented by any subroutine
+calling test routines from Test::More, like ok() or is():
+ local $Test::Builder::Level = $Test::Builder::Level + 1;

Attachment Content-Type Size
tap-builder-level-v2.patch text/x-diff 7.8 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2021-10-07 02:00:51 Re: ALTER INDEX .. RENAME allows to rename tables/views as well
Previous Message Peter Geoghegan 2021-10-07 01:03:11 Re: BUG #17212: pg_amcheck fails on checking temporary relations