Re: More business with $Test::Builder::Level in the TAP tests

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Daniel Gustafsson <daniel(at)yesql(dot)se>
Cc: Andrew Dunstan <andrew(at)dunslane(dot)net>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: More business with $Test::Builder::Level in the TAP tests
Date: 2021-10-08 07:51:41
Message-ID: YV/4jbvS0o/
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On Fri, Oct 08, 2021 at 09:28:04AM +0200, Daniel Gustafsson wrote:
> LGTM. Maybe it should be added that it *must* be called before any Test::More
> function is called, it's sort of self-explanatory but not everyone writing TAP
> tests will be deeply familiar with Perl.

I think that "must" is too strong in this context, as in some cases it
does not really make sense to increment the level, when using for
example a rather long routine that's labelled with one of the
routine arguments like for pg_rewind. So I would stick with

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Daniel Gustafsson 2021-10-08 08:03:42 Re: pgsql: Adjust configure to insist on Perl version >= 5.8.3.
Previous Message Kyotaro Horiguchi 2021-10-08 07:50:55 Re: [BUG] Logical replication failure "ERROR: could not map filenode "base/13237/442428" to relation OID" with catalog modifying txns