| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Andrew Dunstan <andrew(at)dunslane(dot)net>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: More business with $Test::Builder::Level in the TAP tests |
| Date: | 2021-10-08 08:06:04 |
| Message-ID: | 84CDB9AE-9A04-419A-A51F-E61A36AB3272@yesql.se |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 8 Oct 2021, at 09:51, Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Fri, Oct 08, 2021 at 09:28:04AM +0200, Daniel Gustafsson wrote:
>> LGTM. Maybe it should be added that it *must* be called before any Test::More
>> function is called, it's sort of self-explanatory but not everyone writing TAP
>> tests will be deeply familiar with Perl.
>
> I think that "must" is too strong in this context, as in some cases it
> does not really make sense to increment the level, when using for
> example a rather long routine that's labelled with one of the
> routine arguments like for pg_rewind. So I would stick with
> "should".
Fair enough.
--
Daniel Gustafsson https://vmware.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Takashi Menjo | 2021-10-08 08:07:45 | Re: Map WAL segment files on PMEM as WAL buffers |
| Previous Message | Daniel Gustafsson | 2021-10-08 08:03:42 | Re: pgsql: Adjust configure to insist on Perl version >= 5.8.3. |