| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Support "postgres -C" with runtime-computed GUCs |
| Date: | 2021-09-17 23:18:58 |
| Message-ID: | YUUiYvhR+Kpuafj+@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
On Fri, Sep 17, 2021 at 03:18:38PM -0400, Andrew Dunstan wrote:
> The fixups for command_checks_all should go before the loops, not inside
> them.
Right.
> I would probably add a single line like this just after the call that
> checks the status:
>
> foreach ($stderr, $stdout) { s/\r\n/\n/g if $Config{osname} eq 'msys'; }
Yes, that works. Fine by me to use this grammar.
> although maybe perltidy would reformat that.
And perltidy tells me nothing here.
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| fix-tap-msys-crlf-2.patch | text/plain | 2.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2021-09-18 01:50:59 | pgsql: Improve some check logic in pg_receivewal |
| Previous Message | Peter Geoghegan | 2021-09-17 21:21:25 | pgsql: pageinspect: Make page deletion elog less chatty. |