Re: Remove duplicate static function check_permissions in slotfuncs.c and logicalfuncs.c

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>
Cc: Euler Taveira <euler(at)eulerto(dot)com>, "Bossart, Nathan" <bossartn(at)amazon(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Remove duplicate static function check_permissions in slotfuncs.c and logicalfuncs.c
Date: 2021-09-14 01:23:48
Message-ID: YT/5pL84LufxjSue@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Sep 13, 2021 at 08:51:18AM +0530, Bharath Rupireddy wrote:
> On Mon, Sep 13, 2021 at 8:07 AM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>> On Sun, Sep 12, 2021 at 10:14:36PM -0300, Euler Taveira wrote:
>>> On Sun, Sep 12, 2021, at 8:02 PM, Bossart, Nathan wrote:
>>>> nitpick: It looks like there's an extra set of parentheses around
>>>> errmsg().
>>>
>>> Indeed. Even the requirement for extra parenthesis around auxiliary function
>>> calls was removed in v12 (e3a87b4991cc2d00b7a3082abb54c5f12baedfd1).

Applied. Not using those extra parenthesis is the most common
pattern, so tweaked this way.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2021-09-14 01:32:55 Re: Don't clean up LLVM state when exiting in a bad way
Previous Message houzj.fnst@fujitsu.com 2021-09-14 01:01:46 RE: Added schema level support for publication.