Re: Remove duplicate static function check_permissions in slotfuncs.c and logicalfuncs.c

On 2021-Sep-14, Michael Paquier wrote:

> On Mon, Sep 13, 2021 at 08:51:18AM +0530, Bharath Rupireddy wrote:
> > On Mon, Sep 13, 2021 at 8:07 AM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> >> On Sun, Sep 12, 2021 at 10:14:36PM -0300, Euler Taveira wrote:
> >>> On Sun, Sep 12, 2021, at 8:02 PM, Bossart, Nathan wrote:
> >>>> nitpick: It looks like there's an extra set of parentheses around
> >>>> errmsg().
> >>>
> >>> Indeed. Even the requirement for extra parenthesis around auxiliary function
> >>> calls was removed in v12 (e3a87b4991cc2d00b7a3082abb54c5f12baedfd1).
>
> Applied. Not using those extra parenthesis is the most common
> pattern, so tweaked this way.

The parentheses that commit e3a87b4991cc removed the requirement for are
those that the committed code still has, starting at the errcode() line.
The ones in errmsg() were redundant and have never been necessary.

--
Álvaro Herrera Valdivia, Chile — https://www.EnterpriseDB.com/
"El sabio habla porque tiene algo que decir;
el tonto, porque tiene que decir algo" (Platon).