Re: bugfix: when the blocksize is 32k, the function page_header of pageinspect returns negative numbers.

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Quan Zongliang <quanzongliang(at)yeah(dot)net>
Cc: Justin Pryzby <pryzby(at)telsasoft(dot)com>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: bugfix: when the blocksize is 32k, the function page_header of pageinspect returns negative numbers.
Date: 2021-07-09 05:16:54
Message-ID: YOfbgfpC4uy+l/NZ@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Jul 09, 2021 at 11:11:46AM +0800, Quan Zongliang wrote:
> Thanks for the comments.

Thanks. Having four switches is a bit repetitive so I would just use
one of these, and perhaps complete with some assertions to make sure
that atttypid matches to what is expected. That's a minor comment
though, this looks rather fine to me reading through.
--
Michael

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2021-07-09 05:37:34 Re: [PoC] Improve dead tuple storage for lazy vacuum
Previous Message Fabien COELHO 2021-07-09 05:14:32 Re: pgbench logging broken by time logic changes