Re: PXGS vs TAP tests

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Noah Misch <noah(at)leadboat(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: PXGS vs TAP tests
Date: 2021-06-22 00:23:42
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On Sun, Jun 20, 2021 at 01:24:04PM -0400, Andrew Dunstan wrote:
> Tests pass with the attached patch, which puts the setting in the
> Makefile for the recovery tests. The script itself doesn't need any
> changing.

It may be better to add a comment here explaning why REGRESS_SHLIB is
required in this Makefile then?

While on it, could we split those commands into multiple lines and
reduce the noise of future diffs? Something as simple as that would
make those prove commands easier to follow:
+cd $(srcdir) && TESTDIR='$(CURDIR)' \
+ $(with_temp_install) \
+ PG_REGRESS='$(CURDIR)/$(top_builddir)/src/test/regress/pg_regress' \
+ REGRESS_SHLIB= '$(abs_top_builddir)/src/test/regress/regress$(DLSUFFIX)' \

There are other places where this could happen, but the TAP commands
are particularly long.

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2021-06-22 00:25:27 Re: pgbench logging broken by time logic changes
Previous Message Justin Pryzby 2021-06-22 00:19:27 Re: Different compression methods for FPI