Re: Teach pg_receivewal to use lz4 compression

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: gkokolatos(at)pm(dot)me
Cc: Magnus Hagander <magnus(at)hagander(dot)net>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Teach pg_receivewal to use lz4 compression
Date: 2021-07-02 01:10:16
Message-ID: YN5nePsQJhMLhznM@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Jul 01, 2021 at 02:10:17PM +0000, gkokolatos(at)pm(dot)me wrote:
> Micheal suggested on the same thread to move my entry in the help output so that
> the output remains ordered. I would like the options for the compression method and
> the already existing compression level to next to each other if possible. Then it
> should be either 'X' or 'Y'.

Hmm. Grouping these together makes sense for the user. One choice
that we have here is to drop the short option, and just use a long
one. What I think is important for the user when it comes to this
option is the consistency of its naming across all the tools
supporting it. pg_dump and pg_basebackup, where we could plug LZ4,
already use most of the short options you could use for pg_receivewal,
having only a long one gives a bit more flexibility.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2021-07-02 01:23:32 Re: cutting down the TODO list thread
Previous Message Amit Langote 2021-07-02 00:47:32 Re: New committers: Daniel Gustafsson and John Naylor