Re: pg_regress.c also sensitive to various PG* environment variables

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Cc: Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: pg_regress.c also sensitive to various PG* environment variables
Date: 2021-06-12 00:10:06
Message-ID: YMP7XlGARe1v2MpZ@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Jun 11, 2021 at 10:08:20AM -0400, Alvaro Herrera wrote:
> I think if they're to be kept in sync, then the exceptions should be
> noted. I mean, where PGCLIENTENCODING would otherwise be, I'd add
> /* PGCLIENTENCODING set above */
> /* See below for PGHOSTADDR */
> and so on (PGHOST and PGPORT probably don't need this because they're
> immediately below; not sure; but I would put them in alphabetical order
> in both lists for sure and then that wouldn't apply). Otherwise I would
> think that it's an omission and would set to fix it.

Good idea, thanks. I'll add comments for each one that cannot be
unsetted.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2021-06-12 00:32:44 Re: array_cat anycompatible change is breaking xversion upgrade tests (v14 release notes)
Previous Message Jacob Champion 2021-06-11 23:53:23 Re: Table AM modifications to accept column projection lists