Re: Error on pgbench logs

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
Cc: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, rulyox(at)gmail(dot)com, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Error on pgbench logs
Date: 2021-06-11 06:23:41
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On Thu, Jun 10, 2021 at 11:29:30PM +0200, Fabien COELHO wrote:
> + /* flush remaining stats */
> + if (!logged && latency == 0.0)
> + logAgg(logfile, agg);

You are right, this is missing the final stats. Why the choice of
latency here for the check? That's just to make the difference
between the case where doLog() is called while processing the
benchmark for the end of the transaction and the case where doLog() is
called once a thread ends, no? Wouldn't it be better to do a final
push of the states once a thread reaches CSTATE_FINISHED or

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Langote 2021-06-11 06:26:05 Re: Multi-Column List Partitioning
Previous Message Jeff Davis 2021-06-11 06:22:53 Re: Question about StartLogicalReplication() error path