Re: [DOC] add missing "[ NO ]" to various "DEPENDS ON" synopses

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Ian Lawrence Barwick <barwick(at)gmail(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [DOC] add missing "[ NO ]" to various "DEPENDS ON" synopses
Date: 2021-02-13 02:52:51
Message-ID: YCc/A3BFNmzi4gBK@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Feb 12, 2021 at 10:32:14AM +0900, Ian Lawrence Barwick wrote:
> In the documentation, the "[ NO ]" option is listed in the synopsis for
> ALTER TRIGGER and ALTER FUNCTION, but not the others.
> Trivial patch attached.

There are two flavors to cover for 6 commands per gram.y, and you are
covering all of them. So this looks good to me. I'll apply and
backpatch in a bit. It is worth noting that tab-complete.c does a bad
job in completing those clauses.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Masahiko Sawada 2021-02-13 03:18:36 Re: [PoC] Non-volatile WAL buffer
Previous Message Michael Paquier 2021-02-13 02:40:23 Re: Possible dereference null return (src/backend/replication/logical/reorderbuffer.c)