| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Juan José Santamaría Flecha <juanjo(dot)santamaria(at)gmail(dot)com> |
| Cc: | robionekenobi(at)bluewin(dot)ch, PostgreSQL mailing lists <pgsql-bugs(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: BUG #16825: When building on Windows, cl /? retrun 'x64' not AMD64 and the build does not create x64 environment |
| Date: | 2021-01-20 07:24:47 |
| Message-ID: | YAfav21sjbWJORCy@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On Tue, Jan 19, 2021 at 09:31:22AM +0100, Juan José Santamaría Flecha wrote:
> The scripts assume that the 'msvc' folder is three levels deep,
> 'src/tools/msvc'. If you respect that, you can build with the 'cl /help'
> patch. Please find attached the patch for so.
So, I have been playing with subst and some virtual drives, and this
allows to run builds if for example pointing to the top of a git repo,
which is fancy.
Requiring at least three repository levels is something that we are
going to need anyway as a build requires a full access to the tree,
but I really see no reason to help users with such configurations as
that's basically free for us to do so. I can see the difference of
output between cl /? and /help for virtual drives, and that's really
surprising, but I see no reason to not apply this patch as this breaks
nothing and /help is an official option.
If there are no objections, I am planning to apply this patch to
HEAD.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Duncan Sands | 2021-01-20 08:23:14 | Re: Reproducible GIST index corruption under concurrent updates |
| Previous Message | Simon Riggs | 2021-01-20 06:58:09 | Bug in error reporting for multi-line JSON |