Re: cleanup in open_auth_file

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Ted Yu <yuzhihong(at)gmail(dot)com>
Cc: Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: cleanup in open_auth_file
Date: 2022-11-24 01:19:16
Message-ID: Y37GlHVLR6UUvso+@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Nov 23, 2022 at 05:09:22PM -0800, Ted Yu wrote:
> Thinking more on this.
> The context should be created when the file is successfully opened.

Indeed. Both operations ought to be done in the reverse order, or we
would run into leaks in the postmaster on reload if pg_ident.conf has
been removed, for example, and this is prefectly valid. That's what
the previous logic did, actually. Will fix in a minute..
--
Michael

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2022-11-24 01:35:31 Re: More efficient build farm animal wakeup?
Previous Message Andrew Dunstan 2022-11-24 01:15:42 Re: ssl tests aren't concurrency safe due to get_free_port()