| From: | Ted Yu <yuzhihong(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: cleanup in open_auth_file |
| Date: | 2022-11-24 01:09:22 |
| Message-ID: | CALte62xsDNY9MornAnYzR=vGW6VCYK9Qa1=UMEvcM2RLs-vZrg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Nov 23, 2022 at 4:54 PM Ted Yu <yuzhihong(at)gmail(dot)com> wrote:
> Hi,
> I was looking at the following commit:
>
> commit efc981627a723d91e86865fb363d793282e473d1
> Author: Michael Paquier <michael(at)paquier(dot)xyz>
> Date: Thu Nov 24 08:21:55 2022 +0900
>
> Rework memory contexts in charge of HBA/ident tokenization
>
> I think when the file cannot be opened, the context should be deleted.
>
> Please see attached patch.
>
> I also modified one comment where `deleted` would be more appropriate verb
> for the context.
>
> Cheers
>
Thinking more on this.
The context should be created when the file is successfully opened.
Please take a look at patch v2.
| Attachment | Content-Type | Size |
|---|---|---|
| open-auth-file-cleanup-v2.patch | application/octet-stream | 1.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Dunstan | 2022-11-24 01:15:42 | Re: ssl tests aren't concurrency safe due to get_free_port() |
| Previous Message | Thomas Munro | 2022-11-24 01:02:54 | Re: odd buildfarm failure - "pg_ctl: control file appears to be corrupt" |