Re: New docs chapter on Transaction Management and related changes

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Robert Treat <rob(at)xzilla(dot)net>
Cc: Simon Riggs <simon(dot)riggs(at)enterprisedb(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Erik Rijkers <er(at)xs4all(dot)nl>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: New docs chapter on Transaction Management and related changes
Date: 2022-10-16 01:08:15
Message-ID: Y0tZf7N+cUJ9ebPI@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Oct 14, 2022 at 05:46:55PM -0400, Robert Treat wrote:
> On Fri, Oct 14, 2022 at 3:51 PM Bruce Momjian <bruce(at)momjian(dot)us> wrote:
> > Attached is the merged patch from all the great comments I received. I
> > have also rebuilt the docs with the updated patch:
> >
> > https://momjian.us/tmp/pgsql/
> >
>
> + <command>RELEASE SAVEPOINT</command> also subcommits and destroys
> + all savepoints that were established after the named savepoint was
> + established. This means that any subtransactions of the named savepoint
> + will also be subcommitted and destroyed.
>
> Wonder if we should be more explicit that data changes are preserved,
> not destroyed... something like:
> "This means that any changes within subtransactions of the named
> savepoint will be subcommitted and those subtransactions will be
> destroyed."

Good point. I reread the section and there was just too much confusion
over subtransactions, partly because the behavior just doesn't map
easily to subtransaction. I therefore merged all three paragraphs into
one and tried to make the text saner; release_savepoint.sgml diff
attached, URL content updated.

--
Bruce Momjian <bruce(at)momjian(dot)us> https://momjian.us
EDB https://enterprisedb.com

Indecision is a decision. Inaction is an action. Mark Batterson

Attachment Content-Type Size
xact.diff text/x-diff 3.2 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Zhihong Yu 2022-10-16 01:36:51 Re: PATCH: Using BRIN indexes for sorted output
Previous Message Tom Lane 2022-10-16 01:00:00 Re: macos ventura SDK spews warnings