Re: Provide PID data for "cannot wait on a latch owned by another process" in latch.c

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Provide PID data for "cannot wait on a latch owned by another process" in latch.c
Date: 2023-02-27 23:59:22
Message-ID: Y/1D2q7YD5GxasCt@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Feb 27, 2023 at 05:48:10PM +0900, Kyotaro Horiguchi wrote:
> +1 for adding that information, I'm afraid that MyProcId is not
> necessary since it is displayed in log lines in most cases. If you
> want to display the both PIDs I suggest making them more distinctive.

What would you suggest? This message is basically impossible to
reach so the wording of the patch was OK for me (see async.c) so you
would need to look at the internals anyway. Now if you'd like
something like "could not blah: owner PID=%d, MyProcPid=%d", that's
also fine by me.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2023-02-28 00:01:48 Re: verbose mode for pg_input_error_message?
Previous Message Vik Fearing 2023-02-27 23:38:21 Re: Adding argument names to aggregate functions