Re: Provide PID data for "cannot wait on a latch owned by another process" in latch.c

From: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>
To: michael(at)paquier(dot)xyz
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Provide PID data for "cannot wait on a latch owned by another process" in latch.c
Date: 2023-02-27 08:48:10
Message-ID: 20230227.174810.462663414355965707.horikyota.ntt@gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

At Mon, 27 Feb 2023 09:20:39 +0900, Michael Paquier <michael(at)paquier(dot)xyz> wrote in
> Hi all,
>
> While doing something I should not have done, I have been able to
> trigger latch.c with the error of $subject. Adding in the elog
> generated some information about the PID owning the latch and
> MyProcPid has made me understand immediately why I was wrong. Would
> there be any objections to add more information in this case?
>
> The attached patch does so.
> Thanks,

Please tidy up the followging sentence properly and natural but in a moderately formal way, within the context of computer programs, and provide explanations for the individual changes you made.

+1 for adding that information, I'm afraid that MyProcId is not
necessary since it is displayed in log lines in most cases. If you
want to display the both PIDs I suggest making them more distinctive.

regards.

--
Kyotaro Horiguchi
NTT Open Source Software Center

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Hayato Kuroda (Fujitsu) 2023-02-27 08:51:29 RE: Time delayed LR (WAS Re: logical replication restrictions)
Previous Message Drouvot, Bertrand 2023-02-27 08:40:58 Re: Minimal logical decoding on standbys