| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
| Cc: | Pavel Borisov <pashkin(dot)elfe(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: BUG #16663: DROP INDEX did not free up disk space: idle connection hold file marked as deleted |
| Date: | 2020-12-01 02:55:34 |
| Message-ID: | X8WwpscE7CT9UPHD@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs pgsql-hackers |
On Mon, Nov 30, 2020 at 06:59:40PM +1300, Thomas Munro wrote:
> So I fixed that, by adding a return value to do_truncate() and
> checking it. That's the version I plan to commit tomorrow, unless
> there are further comments or objections. I've also attached a
> version suitable for REL_11_STABLE and earlier branches (with a name
> that cfbot should ignore), where things are slightly different. In
> those branches, the register_forget_request() logic is elsewhere.
Hmm. Sorry for arriving late at the party. But is that really
something suitable for a backpatch? Sure, it is not optimal to not
truncate all the segments when a transaction dropping a relation
commits, but this was not completely broken either.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Thomas Munro | 2020-12-01 03:06:48 | Re: BUG #16663: DROP INDEX did not free up disk space: idle connection hold file marked as deleted |
| Previous Message | Thomas Munro | 2020-12-01 02:48:31 | Re: BUG #16663: DROP INDEX did not free up disk space: idle connection hold file marked as deleted |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Thomas Munro | 2020-12-01 03:06:48 | Re: BUG #16663: DROP INDEX did not free up disk space: idle connection hold file marked as deleted |
| Previous Message | Tom Lane | 2020-12-01 02:48:52 | Re: Huge memory consumption on partitioned table with FKs |