Re: pgsql: Add pg_alterckey utility to change the cluster key

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Bruce Momjian <bruce(at)momjian(dot)us>, pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Add pg_alterckey utility to change the cluster key
Date: 2020-12-26 03:49:58
Message-ID: X+ay5orW8bgwWqI1@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Fri, Dec 25, 2020 at 10:36:55PM -0500, Tom Lane wrote:
> 3. The buildfarm says this commit is (still) busted on Win32.
>
> Possibly these commits need more review than you think.

Shared feeling here, I think that this is still too early. FWIW, I am
surprised that this patch series includes exactly zero line of code
for tests, while the total amount of code committed is close to 3000
lines.
--
Michael

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Pavel Stehule 2020-12-26 05:18:01 Re: pgsql: Add pg_alterckey utility to change the cluster key
Previous Message Bruce Momjian 2020-12-26 03:47:28 pgsql: pg_alterckey: adjust doc build and Win32 sleep/open build fails

Browse pgsql-hackers by date

  From Date Subject
Next Message Pavel Stehule 2020-12-26 04:52:44 Re: proposal: schema variables
Previous Message Bruce Momjian 2020-12-26 03:40:37 Re: pgsql: Add pg_alterckey utility to change the cluster key