Re: pgsql: Add pg_alterckey utility to change the cluster key

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Add pg_alterckey utility to change the cluster key
Date: 2020-12-26 03:36:55
Message-ID: 1252111.1608953815@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Bruce Momjian <bruce(at)momjian(dot)us> writes:
> Add pg_alterckey utility to change the cluster key

> Modified Files
> --------------
> doc/src/sgml/ref/pg_alterkey.sgml | 186 ++++++++++

1. I wonder why this file is "pg_alterkey.sgml" when the
program it documents is pg_alterckey.

2. Regardless of name, this file is dead code because you did not
hook it into the documentation infrastructure.

3. The buildfarm says this commit is (still) busted on Win32.

Possibly these commits need more review than you think.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Bruce Momjian 2020-12-26 03:40:37 Re: pgsql: Add pg_alterckey utility to change the cluster key
Previous Message Bruce Momjian 2020-12-26 01:50:02 pgsql: Fix function call typo in frontend Win32 code, commit 978f869b99

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2020-12-26 03:40:37 Re: pgsql: Add pg_alterckey utility to change the cluster key
Previous Message tsunakawa.takay@fujitsu.com 2020-12-26 01:56:02 RE: [bug fix] ALTER TABLE SET LOGGED/UNLOGGED on a partitioned table does nothing silently