From: | Andreas Joseph Krogh <andreas(at)visena(dot)com> |
---|---|
To: | Guillaume Lelarge <guillaume(at)lelarge(dot)info> |
Cc: | amul sul <sulamul(at)gmail(dot)com>, PostgreSQL General <pgsql-general(at)postgresql(dot)org> |
Subject: | Re: Exclude pg_largeobject form pg_dump |
Date: | 2016-11-08 00:06:47 |
Message-ID: | VisenaEmail.2c.f3a091fe0c264347.1584139e60e@tc7-visena |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-general pgsql-hackers |
På mandag 07. november 2016 kl. 22:01:41, skrev Guillaume Lelarge <
guillaume(at)lelarge(dot)info <mailto:guillaume(at)lelarge(dot)info>>:
2016-11-07 7:06 GMT+01:00 amul sul <sulamul(at)gmail(dot)com
<mailto:sulamul(at)gmail(dot)com>>: On Mon, Nov 7, 2016 at 2:03 AM, Guillaume Lelarge
<guillaume(at)lelarge(dot)info <mailto:guillaume(at)lelarge(dot)info>> wrote:
>>
>> Agreed. I was afraid of that, but for some reason, didn't find that. I'll
>> fix this.
>
>
> Fixed in v4.
>
This fix is broken.
70 - if (dopt.include_everything && !dopt.schemaOnly)
71 + if (dopt.include_everything && !dopt.schemaOnly && !dopt.outputBlobs)
72 dopt.outputBlobs = true;
dopt.outputBlobs set to FALSE when option -B is specified and this IF
condition reverts to TRUE which force to dump blobs.
I don't see what you mean. It forces dump of Blobs if we didn't use -B and if
we include everything in the dump, which seems good to me. What did you try
that didn't work as expected?
I guess what he means is that if -B is given, the following code
sets dopt.outputBlobs = false
+ case 'B': /* Don't dump blobs */
+ dopt.outputBlobs = false;
+ break;
Then this IF sets it back to TRUE:
+ if (dopt.include_everything && !dopt.schemaOnly && !dopt.outputBlobs)
dopt.outputBlobs = true;
...making it impossible to turn off dumping of blobs.
-- Andreas Joseph Krogh
CTO / Partner - Visena AS
Mobile: +47 909 56 963
andreas(at)visena(dot)com <mailto:andreas(at)visena(dot)com>
www.visena.com <https://www.visena.com>
From | Date | Subject | |
---|---|---|---|
Next Message | Michael Paquier | 2016-11-08 02:17:31 | Re: checkpoint_timout with no WAL activity |
Previous Message | Guillaume Lelarge | 2016-11-07 21:01:41 | Re: Exclude pg_largeobject form pg_dump |
From | Date | Subject | |
---|---|---|---|
Next Message | Michael Paquier | 2016-11-08 00:25:46 | Re: add more NLS to bin |
Previous Message | Jeff Janes | 2016-11-07 23:42:52 | Re: Remove the comment on the countereffectiveness of large shared_buffers on Windows |