Re: Exclude pg_largeobject form pg_dump

From: amul sul <sulamul(at)gmail(dot)com>
To: Andreas Joseph Krogh <andreas(at)visena(dot)com>
Cc: Guillaume Lelarge <guillaume(at)lelarge(dot)info>, PostgreSQL General <pgsql-general(at)postgresql(dot)org>
Subject: Re: Exclude pg_largeobject form pg_dump
Date: 2016-11-08 05:01:35
Message-ID: CAAJ_b94f7cGtwH0Gw2Om4Gm8mU2nMqpA1DunfJjv0sVD3WML3g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-general pgsql-hackers

On Tue, Nov 8, 2016 at 5:36 AM, Andreas Joseph Krogh <andreas(at)visena(dot)com> wrote:
>
>
> I don't see what you mean. It forces dump of Blobs if we didn't use -B and
> if we include everything in the dump, which seems good to me. What did you
> try that didn't work as expected?
>
>
> I guess what he means is that if -B is given, the following code sets
> dopt.outputBlobs = false
>
> + case 'B': /* Don't dump blobs */
> + dopt.outputBlobs = false;
> + break;
>
>
> Then this IF sets it back to TRUE:
>
> + if (dopt.include_everything && !dopt.schemaOnly && !dopt.outputBlobs)
> dopt.outputBlobs = true;
>
>
> ...making it impossible to turn off dumping of blobs.
>

Yes, thats the reason v4 patch was not as expected.

Regards,
Amul Sul

In response to

Responses

Browse pgsql-general by date

  From Date Subject
Next Message Gadamsetty, Kiran 2016-11-08 05:01:39 Re: Linux equivalent library for "postgres.lib" from Windows
Previous Message John R Pierce 2016-11-08 04:32:04 Re: Linux equivalent library for "postgres.lib" from Windows

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2016-11-08 05:11:27 Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled
Previous Message Thomas Munro 2016-11-08 04:56:52 SERIALIZABLE on standby servers