| From: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com> |
|---|---|
| To: | 'Amit Kapila' <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | Peter Smith <smithpb2250(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, "shiy(dot)fnst(at)fujitsu(dot)com" <shiy(dot)fnst(at)fujitsu(dot)com>, Melih Mutlu <m(dot)melihmutlu(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, Euler Taveira <euler(at)eulerto(dot)com>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, "Takamichi Osumi (Fujitsu)" <osumi(dot)takamichi(at)fujitsu(dot)com> |
| Subject: | RE: PGdoc: add missing ID attribute to create_subscription.sgml |
| Date: | 2023-03-28 07:30:15 |
| Message-ID: | TYAPR01MB58663460C0EA4577DD0257D1F5889@TYAPR01MB5866.jpnprd01.prod.outlook.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Dear Amit,
Thank you for reviewing! PSA new version.
> Isn't it better to move the link-related part to the next line
> wherever possible? Currently, it looks bit odd.
Previously I preferred not to add a new line inside the <link> tag, but it caused
long-line. So I adjusted them not to be too short/long length.
> Why 0002 patch is part of this thread? I thought here we want to add
> 'ids' to entries corresponding to Create Subscription as we have added
> the one in commit ecb696.
>
0002 was motivated by Peter's comment [1]. This exceeds the initial intention of
the patch, so I removed once.
Best Regards,
Hayato Kuroda
FUJITSU LIMITED
| Attachment | Content-Type | Size |
|---|---|---|
| v6-0001-Add-XML-ID-attributes-to-create_subscription.sgml.patch | application/octet-stream | 18.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jelte Fennema | 2023-03-28 07:33:27 | Re: [EXTERNAL] Support load balancing in libpq |
| Previous Message | Chris Travers | 2023-03-28 07:28:40 | Re: Moving forward with TDE |