| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com> |
| Cc: | Peter Smith <smithpb2250(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, "shiy(dot)fnst(at)fujitsu(dot)com" <shiy(dot)fnst(at)fujitsu(dot)com>, Melih Mutlu <m(dot)melihmutlu(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, Euler Taveira <euler(at)eulerto(dot)com>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, "Takamichi Osumi (Fujitsu)" <osumi(dot)takamichi(at)fujitsu(dot)com> |
| Subject: | Re: PGdoc: add missing ID attribute to create_subscription.sgml |
| Date: | 2023-03-28 06:33:23 |
| Message-ID: | CAA4eK1JkQY-hhcCOY+-gRLk3CuNLBTsx_15pm3XZobr1Px2RJA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Mar 28, 2023 at 9:49 AM Hayato Kuroda (Fujitsu)
<kuroda(dot)hayato(at)fujitsu(dot)com> wrote:
>
> Thank you for prompt reply!
>
> > Hmm, my above-suggested wording was “publish_via_partition_root
> > parameter “ but it seems you (accidentally?) omitted the word
> > “parameter”.
>
> It is my carelessness, sorry for inconvenience. PSA new ones.
>
In 0001, patch, I see a lot of long lines like below:
- subscription can be used with the
<literal>disable_on_error</literal> option.
- Then, you can use
<function>pg_replication_origin_advance()</function> function
- with the <parameter>node_name</parameter> (i.e.,
<literal>pg_16395</literal>)
+ subscription can be used with the <link
linkend="sql-createsubscription-with-disable-on-error"><literal>disable_on_error</literal></link>
Isn't it better to move the link-related part to the next line
wherever possible? Currently, it looks bit odd.
Why 0002 patch is part of this thread? I thought here we want to add
'ids' to entries corresponding to Create Subscription as we have added
the one in commit ecb696.
--
With Regards,
Amit Kapila.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Laurenz Albe | 2023-03-28 06:35:57 | Re: Make EXPLAIN generate a generic plan for a parameterized query |
| Previous Message | houzj.fnst@fujitsu.com | 2023-03-28 06:22:20 | RE: Support logical replication of DDLs |