From: | <shohei(dot)mochizuki(at)toshiba(dot)co(dot)jp> |
---|---|
To: | <etsuro(dot)fujita(at)gmail(dot)com> |
Cc: | <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>, <tgl(at)sss(dot)pgh(dot)pa(dot)us>, <pgsql-hackers(at)postgresql(dot)org> |
Subject: | RE: BEFORE UPDATE trigger on postgres_fdw table not work |
Date: | 2019-06-13 11:16:13 |
Message-ID: | TYAPR01MB337692EB41FDF2593F42FACAD5EF0@TYAPR01MB3376.jpnprd01.prod.outlook.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Fujita-san,
> From: Etsuro Fujita [mailto:etsuro(dot)fujita(at)gmail(dot)com]
>
> Mochizuki-san,
>
> On Wed, Jun 12, 2019 at 6:08 PM <shohei(dot)mochizuki(at)toshiba(dot)co(dot)jp> wrote:
> > > On Mon, Jun 10, 2019 at 9:04 PM Etsuro Fujita
> > > <etsuro(dot)fujita(at)gmail(dot)com>
> > > wrote:
> > > > I'll look into the patch more closely tomorrow.
> > >
> > > I did that, but couldn't find any issue about the patch. Here is an
> > > updated version of the patch. Changes are:
> > >
> > > * Reworded the comments a bit in postgresPlanFoereignModify the
> > > original patch modified
> > > * Added the commit message
>
> > I think your wording is more understandable than my original patch.
>
> Great! I've pushed the patch after updating the comment as proposed by
> Amit-san yesterday, and adding a regression test case checking EXPLAIN
> because otherwise we wouldn't have any EXPLAIN results in v9.4.
>
> Thanks for the report and fix!
Thanks for the commit!
--
Shohei Mochizuki
From | Date | Subject | |
---|---|---|---|
Next Message | Masahiko Sawada | 2019-06-13 12:30:34 | Re: pg_upgrade: Improve invalid option handling |
Previous Message | Masahiko Sawada | 2019-06-13 11:01:22 | Re: [PATCH] Speedup truncates of relation forks |