| From: | Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com> |
|---|---|
| To: | Shohei Mochizuki <shohei(dot)mochizuki(at)toshiba(dot)co(dot)jp> |
| Cc: | Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: BEFORE UPDATE trigger on postgres_fdw table not work |
| Date: | 2019-06-13 09:22:41 |
| Message-ID: | CAPmGK15wYher5pdOBPQZvwiZHBgPTuWh-=RwEY-SxC_MfP7i0g@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Mochizuki-san,
On Wed, Jun 12, 2019 at 6:08 PM <shohei(dot)mochizuki(at)toshiba(dot)co(dot)jp> wrote:
> > On Mon, Jun 10, 2019 at 9:04 PM Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com>
> > wrote:
> > > I'll look into the patch more closely tomorrow.
> >
> > I did that, but couldn't find any issue about the patch. Here is an updated
> > version of the patch. Changes are:
> >
> > * Reworded the comments a bit in postgresPlanFoereignModify the original
> > patch modified
> > * Added the commit message
> I think your wording is more understandable than my original patch.
Great! I've pushed the patch after updating the comment as proposed
by Amit-san yesterday, and adding a regression test case checking
EXPLAIN because otherwise we wouldn't have any EXPLAIN results in
v9.4.
Thanks for the report and fix!
Best regards,
Etsuro Fujita
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jamison, Kirk | 2019-06-13 09:30:00 | RE: [PATCH] Speedup truncates of relation forks |
| Previous Message | movead li | 2019-06-13 08:33:19 | Re: Rearranging ALTER TABLE to avoid multi-operations bugs |