RE: Remove unused argument from ApplyLogicalMappingFile()

From: "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>
To: 'Yugo Nagata' <nagata(at)sraoss(dot)co(dot)jp>
Cc: Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: RE: Remove unused argument from ApplyLogicalMappingFile()
Date: 2026-01-28 05:18:15
Message-ID: TY7PR01MB1455477C72A1765233D7D13D4F591A@TY7PR01MB14554.jpnprd01.prod.outlook.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Dear Nagata-san,

> I noticed that ApplyLogicalMappingFile() has an unused argument.
> If there is no specific reason for keeping it, I think it could be
> removed. I have attached a small patch that removes this argument.

Good catch. I found that ApplyLogicalMappingFile() has the argument since it was
introduced (b89e151) and was not used from the beginning. Maybe it was a
copy-to-paste mistake from UpdateLogicalMappings()?
I removed the argument and ran tests for subscription, they could be passed.

Best regards,
Hayato Kuroda
FUJITSU LIMITED

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Soumya S Murali 2026-01-28 05:23:24 Re: Pasword expiration warning
Previous Message shveta malik 2026-01-28 05:16:07 Re: Skipping schema changes in publication