| From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
|---|---|
| To: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com> |
| Cc: | Yugo Nagata <nagata(at)sraoss(dot)co(dot)jp>, Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Remove unused argument from ApplyLogicalMappingFile() |
| Date: | 2026-01-28 09:23:47 |
| Message-ID: | CAHGQGwFFZg6Zehej4o-YKUn59R4+ugtowmCU+kbteQizqnYsBw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Jan 28, 2026 at 2:18 PM Hayato Kuroda (Fujitsu)
<kuroda(dot)hayato(at)fujitsu(dot)com> wrote:
>
> Dear Nagata-san,
>
> > I noticed that ApplyLogicalMappingFile() has an unused argument.
> > If there is no specific reason for keeping it, I think it could be
> > removed. I have attached a small patch that removes this argument.
Thanks for the patch! I will commit it.
> Good catch. I found that ApplyLogicalMappingFile() has the argument since it was
> introduced (b89e151) and was not used from the beginning.
Yes.
> I removed the argument and ran tests for subscription, they could be passed.
Thanks for the test!
Regards,
--
Fujii Masao
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ahmed Et-tanany | 2026-01-28 10:16:21 | [PATCH] Add max_logical_replication_slots GUC |
| Previous Message | jian he | 2026-01-28 08:53:02 | Re: ON CONFLICT DO SELECT (take 3) |